Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...

keith gerrit-no-reply at lists.osmocom.org
Mon Apr 12 18:16:01 UTC 2021


keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 )

Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.
......................................................................

stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.

Change-Id: Ice3379020039dc3634aa3887939740729d720dee
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/lchan_fsm.c
3 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index c03c75e..d883570 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -64,6 +64,7 @@
 	BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK,
 	BTS_CTR_LCHAN_BORKEN_EV_VTY,
 	BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN,
+	BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR,
 	BTS_CTR_LCHAN_BORKEN_FROM_WAIT_RR_CHAN_MODE_MODIFY_ACK,
 	BTS_CTR_LCHAN_BORKEN_FROM_WAIT_RSL_CHAN_MODE_MODIFY_ACK,
 	BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED,
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index b5b7136..7abc126 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -885,6 +885,9 @@
 	[BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN] = \
 		{ "lchan_borken:event:teardown",
 		  "lchan in a BORKEN state is shutting down (BTS disconnected?)" },
+	[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR] = \
+		{ "lchan_borken:event:ts_error",
+		  "LCHAN_EV_TS_ERROR received in a BORKEN state" },
 	[BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED] = \
 		{ "ts_borken:from_state:not_initialized",
 		  "Transitions from TS NOT_INITIALIZED state to BORKEN state" },
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 6f0fd63..ffcf2b1 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1537,8 +1537,15 @@
 	switch (event) {
 
 	case LCHAN_EV_TS_ERROR:
+	{
+		struct gsm_lchan *lchan = lchan_fi_lchan(fi);
+		if (fi->state == LCHAN_ST_BORKEN) {
+			rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR]);
+			osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN], 1);
+		}
 		lchan_fail_to(LCHAN_ST_UNUSED, "LCHAN_EV_TS_ERROR");
 		return;
+	}
 
 	case LCHAN_EV_RLL_ERR_IND:
 		/* let's just ignore this.  We are already logging the

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18703
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice3379020039dc3634aa3887939740729d720dee
Gerrit-Change-Number: 18703
Gerrit-PatchSet: 5
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210412/ff53b0fc/attachment.htm>


More information about the gerrit-log mailing list