<p>keith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18703">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.<br><br>Change-Id: Ice3379020039dc3634aa3887939740729d720dee<br>---<br>M include/osmocom/bsc/bts.h<br>M src/osmo-bsc/bts.c<br>M src/osmo-bsc/lchan_fsm.c<br>3 files changed, 11 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index c03c75e..d883570 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -64,6 +64,7 @@</span><br><span>     BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK,</span><br><span>     BTS_CTR_LCHAN_BORKEN_EV_VTY,</span><br><span>         BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN,</span><br><span style="color: hsl(120, 100%, 40%);">+     BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR,</span><br><span>    BTS_CTR_LCHAN_BORKEN_FROM_WAIT_RR_CHAN_MODE_MODIFY_ACK,</span><br><span>      BTS_CTR_LCHAN_BORKEN_FROM_WAIT_RSL_CHAN_MODE_MODIFY_ACK,</span><br><span>     BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED,</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index b5b7136..7abc126 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -885,6 +885,9 @@</span><br><span>   [BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN] = \</span><br><span>               { "lchan_borken:event:teardown",</span><br><span>             "lchan in a BORKEN state is shutting down (BTS disconnected?)" },</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR] = \</span><br><span style="color: hsl(120, 100%, 40%);">+                { "lchan_borken:event:ts_error",</span><br><span style="color: hsl(120, 100%, 40%);">+              "LCHAN_EV_TS_ERROR received in a BORKEN state" },</span><br><span>        [BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED] = \</span><br><span>                 { "ts_borken:from_state:not_initialized",</span><br><span>            "Transitions from TS NOT_INITIALIZED state to BORKEN state" },</span><br><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 6f0fd63..ffcf2b1 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1537,8 +1537,15 @@</span><br><span>     switch (event) {</span><br><span> </span><br><span>         case LCHAN_EV_TS_ERROR:</span><br><span style="color: hsl(120, 100%, 40%);">+       {</span><br><span style="color: hsl(120, 100%, 40%);">+             struct gsm_lchan *lchan = lchan_fi_lchan(fi);</span><br><span style="color: hsl(120, 100%, 40%);">+         if (fi->state == LCHAN_ST_BORKEN) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR]);</span><br><span style="color: hsl(120, 100%, 40%);">+                       osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN], 1);</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>            lchan_fail_to(LCHAN_ST_UNUSED, "LCHAN_EV_TS_ERROR");</span><br><span>               return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        case LCHAN_EV_RLL_ERR_IND:</span><br><span>           /* let's just ignore this.  We are already logging the</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18703">change 18703</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18703"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice3379020039dc3634aa3887939740729d720dee </div>
<div style="display:none"> Gerrit-Change-Number: 18703 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>