This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23723 ) Change subject: Use construct for EF_AD in pySim-{shell, prog, read}.py, cards.py ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py@233 PS2, Line 233: ad = EF_AD() You can optionally simplify this to: data = EF_AD().decode_hex(res) Also, I would call it 'parsed' or 'decoded' instead. https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py File pySim/construct.py: https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py@56 PS2, Line 56: FlagRFU=Default(Flag,__RFU_VALUE) cosmetic: inconsistent formatting https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok File pysim-testdata/Fairwaves-SIM.ok: https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok@a46 PS2, Line 46: operation Unrelated change? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I65e0a426f80a619fec38856a30e590f0e726b554 Gerrit-Change-Number: 23723 Gerrit-PatchSet: 2 Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 12 Apr 2021 17:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210412/ccba8605/attachment.htm>