<p><a href="https://gerrit.osmocom.org/c/pysim/+/23723">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py">File pySim-read.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py@233">Patch Set #2, Line 233:</a> <code style="font-family:monospace,monospace">             ad = EF_AD()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can optionally simplify this to:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  data = EF_AD().decode_hex(res)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Also, I would call it 'parsed' or 'decoded' instead.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py">File pySim/construct.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py@56">Patch Set #2, Line 56:</a> <code style="font-family:monospace,monospace">FlagRFU=Default(Flag,__RFU_VALUE)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">cosmetic: inconsistent formatting</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok">File pysim-testdata/Fairwaves-SIM.ok:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok@a46">Patch Set #2, Line 46:</a> <code style="font-family:monospace,monospace">operation</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unrelated change?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23723">change 23723</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23723"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I65e0a426f80a619fec38856a30e590f0e726b554 </div>
<div style="display:none"> Gerrit-Change-Number: 23723 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Falkenber9 <robert.falkenberg@tu-dortmund.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Apr 2021 17:37:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>