Change in osmo-gsm-manuals[master]: common/chapters: extend gb/ns2 chapters

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Apr 10 14:08:07 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393 )

Change subject: common/chapters: extend gb/ns2 chapters
......................................................................


Patch Set 6:

(8 comments)

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc 
File common/chapters/gb-ns2.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@13 
PS4, Line 13: There are a multiple
> Looks odd to me, maybe "there exist multiple ... […]
changed to "There are multiple"


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@62 
PS4, Line 62: hdlcX
> consistency: `hdlcX`
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@96 
PS4, Line 96:   SNS-WEIGHT procedures
> missing dot ending sentence
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@124 
PS4, Line 124: * No use of the NS-RESET, NS-BLOCK or NS-UNBLOCK procedures
> missing dot ending sentence
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@158 
PS4, Line 158: parts
> parts: […]
I would leave it as it is.


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@171 
PS4, Line 171: represent
> represents
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@180 
PS4, Line 180: persitant
> persistent
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393/4/common/chapters/gb-ns2.adoc@185 
PS4, Line 185: describe
> describes
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I902b850528cbc04bd469590babd84cccf64300e8
Gerrit-Change-Number: 23393
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Apr 2021 14:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210410/fe904e68/attachment.htm>


More information about the gerrit-log mailing list