Change in osmo-gbproxy[master]: gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset
gerrit-no-reply at lists.osmocom.org
Fri Apr 9 09:20:05 UTC 2021
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23684 )
Change subject: gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset
Patch Set 1:
> Patch Set 1: Code-Review+1
> I'm not sure if the change to free/re-alloc really is part of the bug fix. It's more like a genreal polict/strategy change, while the actual fix is the memcpy?
> Not trying to be difficult here, but the free/realloc has consequences, like: Are we sure there are no dangling references, ...
We store cell information in both the cell struct and the FSM inst (as well as ra_id in the bvc...)
The memcpy updates the cell, but the bvc reset uses the information stored inside the FSM instance.
So we need to either:
* free/alloc the whole bvc (as I do now)
* reallocate only the fsm inst
* Add functions to update the cell information inside the bssbp fsm
Best would be to consolidate our cell information so everything points to the cell struct (and there is an issue for that), but I see that as a next step.
Wrt. dangling references we already call gbproxy_bvc_free() when the SGSN nse goes down so I figured there should be limited "surprises".
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/23684
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 09 Apr 2021 09:20:05 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log