Change in osmo-gbproxy[master]: gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 9 08:54:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23684 )

Change subject: gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset
......................................................................


Patch Set 1: Code-Review+1

I'm not sure if the change to free/re-alloc really is part of the bug fix.  It's more like a genreal polict/strategy change, while the actual fix is the memcpy?

Not trying to be difficult here, but the free/realloc has consequences, like: Are we sure there are no dangling references, ...


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/23684
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ia94090a0133340b7b284df6ec5b36546da698b37
Gerrit-Change-Number: 23684
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 09 Apr 2021 08:54:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210409/eb605b29/attachment.htm>


More information about the gerrit-log mailing list