Change in libosmocore[master]: deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()

fixeria gerrit-no-reply at lists.osmocom.org
Thu Apr 8 20:19:46 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23682 )

Change subject: deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23682/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/23682/2//COMMIT_MSG@12 
PS2, Line 12: - The enum is named "osmo_bts_features", so the function name lacks the
Well, it's debatable. The enum contains _multiple_ features, while the function returns desc for a single (the given) feature. Not going to block you, just my view on the naming.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9dfdb5e81037b6000effbd340af4e5db0dcfd69c
Gerrit-Change-Number: 23682
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Apr 2021 20:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/cae8dceb/attachment.htm>


More information about the gerrit-log mailing list