Change in libosmocore[master]: deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()

neels gerrit-no-reply at lists.osmocom.org
Thu Apr 8 19:20:05 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/23682

to look at the new patch set (#2).

Change subject: deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()
......................................................................

deprecate osmo_bts_feature_name(), add osmo_bts_features_desc()

The function osmo_bts_feature_name() is ill-named for two reasons:
- it returns descriptive text instead of just a string representation of
  the name.
- The enum is named "osmo_bts_features", so the function name lacks the
  "s" for "features".

Rationale: An upcoming patch adds a function to return just the name,
properly called osmo_bts_features_name(), so deprecate the weirdly named
one first.

Change-Id: I9dfdb5e81037b6000effbd340af4e5db0dcfd69c
---
M include/osmocom/gsm/bts_features.h
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/23682/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9dfdb5e81037b6000effbd340af4e5db0dcfd69c
Gerrit-Change-Number: 23682
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/e8ecef52/attachment.htm>


More information about the gerrit-log mailing list