Change in libosmocore[master]: gprs_ns2: add vty `nse <0-65535> restart sns`

daniel gerrit-no-reply at lists.osmocom.org
Tue Apr 6 14:39:07 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 )

Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23184/1/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/23184/1/src/gb/gprs_ns2_vty.c@1920 
PS1, Line 1920: 	gprs_ns2_free_nsvcs(nse);
> The code was there before the SGSN SNS code :) […]
I think this makes sense in both roles (BSS and SGSN) if it works like the side just restarted.

So:
* BSS-side should restart the SIZE procedure
* SGSN-side should stop sending (and responding to) ALIVE and wait until the BSS starts sending SIZE



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Apr 2021 14:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/5636b580/attachment.htm>


More information about the gerrit-log mailing list