Change in libosmocore[master]: gprs_ns2: add vty `nse <0-65535> restart sns`

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sun Apr 4 17:27:15 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 )

Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23184/1/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/23184/1/src/gb/gprs_ns2_vty.c@1920 
PS1, Line 1920: 	gprs_ns2_free_nsvcs(nse);
> The SGSN cannot re-start SNS.  Only the BSS can do this by sending SNS-SIZE. […]
The code was there before the SGSN SNS code :)
So should we have 2 vty commands, one for BSS and one for SGSN?
The code should work for both. But right, there is no restart for SGSN.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 04 Apr 2021 17:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/40417a11/attachment.htm>


More information about the gerrit-log mailing list