Change in simtrace2[master]: card_emu: Clarify and differentiate F/Fi/F_index/Fi_index

laforge gerrit-no-reply at lists.osmocom.org
Tue Apr 6 09:32:59 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/simtrace2/+/23639

to look at the new patch set (#2).

Change subject: card_emu: Clarify and differentiate F/Fi/F_index/Fi_index
......................................................................

card_emu: Clarify and differentiate F/Fi/F_index/Fi_index

The ISO7816 spec terms are well-defined, let's not abuse them. We used
to consider "Fi" as the "index into the table of F values", while the
spec actually considers Fi as the initial value for F.

Let's make sure we use the terms quite clearly:
* Fi and Di are the initial values for F and D
* F*_index and D*_index are the indexes into the ISO7816-3 Tables

Furthermore, let's track Fi separately from F, as e.g. the waiting
time definition only considers Fi as indicated in the ATR, despite
an actually different F value might have been negotiated via PTS
meanwhile.

Change-Id: Ieb2425e8380a81b79df7b2bd072902994e9c3ee7
Related: OS##1704
---
M firmware/libcommon/include/simtrace_prot.h
M firmware/libcommon/source/card_emu.c
2 files changed, 52 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/39/23639/2
-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ieb2425e8380a81b79df7b2bd072902994e9c3ee7
Gerrit-Change-Number: 23639
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/204417ee/attachment.htm>


More information about the gerrit-log mailing list