Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

Robert Falkenberg gerrit-no-reply at lists.osmocom.org
Mon Apr 5 19:36:55 UTC 2021


Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Set uSIM to 'type approval operations' in EF['AD']
......................................................................


Patch Set 5:

(1 comment)

Thanks_for_the_feedback

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG@7 
PS1, Line 7: S
> Do you think it is advisable for all SIM cards of all users to be programmed for 'type approval' at  […]
Good question. The default value depends on the targeted group that uses this software. I was thinking of research and development here. The explicit request is the best option - full agreement. However, I wanted to be minimally invasive in my initial contributions and I didn't want to make offensive changes to the method signatures with possibly unexpected side effects.
(Apparently this single line change was already too much either. https://osmocom.org/issues/4383 Sorry for that.)

I'm happy to prepare a version with parameters, soon.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Falkenberg <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 05 Apr 2021 19:36:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210405/7400e074/attachment.htm>


More information about the gerrit-log mailing list