Change in simtrace2[master]: cardem: use USART timeout for waiting time

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 4 18:16:14 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23620 )

Change subject: cardem: use USART timeout for waiting time
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libboard/simtrace/include/board.h 
File firmware/libboard/simtrace/include/board.h:

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libboard/simtrace/include/board.h@156 
PS1, Line 156: #ifdef APPLICATION_trace
I don't like that kind of change.  The goal has always been to move to a triple-play firmware.  So this file should define the board's physical capabilities, while the application #defines specify which code to include in the build.


https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/include/tc_etu.h 
File firmware/libcommon/include/tc_etu.h:

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/include/tc_etu.h@a11 
PS1, Line 11: extern void tc_etu_wtime_expired(void *handle);
this will breaks the tests, as they call the functions.


https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/mode_cardemu.c 
File firmware/libcommon/source/mode_cardemu.c:

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/mode_cardemu.c@217 
PS1, Line 217: ("%
not sure we want to make this a non-fatal error. Clearly this should never happen...


https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/tc_etu.c 
File firmware/libcommon/source/tc_etu.c:

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/tc_etu.c@91 
PS1, Line 91: card_emu_wt_halfed
see the other comment; the tests need to be updated accordingly.

/usr/bin/ld: /space/home/laforge/projects/git/simtrace2/firmware/test/../libcommon/source/card_emu.c:845: undefined reference to `card_emu_uart_update_wt'


https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libosmocore/include/osmocom/core/utils.h 
File firmware/libosmocore/include/osmocom/core/utils.h:

https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libosmocore/include/osmocom/core/utils.h@78 
PS1, Line 78:  * \param[in] newstr String that will be copied to newly allocated string */
unrelated spelling fixes, should go in separate commit.



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23620
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb2c8cace9137695adf5fb3de43566f7cfb93b5
Gerrit-Change-Number: 23620
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de>
Gerrit-Comment-Date: Sun, 04 Apr 2021 18:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/c20feaf3/attachment.htm>


More information about the gerrit-log mailing list