<p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libboard/simtrace/include/board.h">File firmware/libboard/simtrace/include/board.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libboard/simtrace/include/board.h@156">Patch Set #1, Line 156:</a> <code style="font-family:monospace,monospace">#ifdef APPLICATION_trace</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't like that kind of change.  The goal has always been to move to a triple-play firmware.  So this file should define the board's physical capabilities, while the application #defines specify which code to include in the build.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/include/tc_etu.h">File firmware/libcommon/include/tc_etu.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/include/tc_etu.h@a11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">extern void tc_etu_wtime_expired(void *handle);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this will breaks the tests, as they call the functions.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/mode_cardemu.c">File firmware/libcommon/source/mode_cardemu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/mode_cardemu.c@217">Patch Set #1, Line 217:</a> <code style="font-family:monospace,monospace">("%</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">not sure we want to make this a non-fatal error. Clearly this should never happen...</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/tc_etu.c">File firmware/libcommon/source/tc_etu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libcommon/source/tc_etu.c@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace">card_emu_wt_halfed</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">see the other comment; the tests need to be updated accordingly.</p><p style="white-space: pre-wrap; word-wrap: break-word;">/usr/bin/ld: /space/home/laforge/projects/git/simtrace2/firmware/test/../libcommon/source/card_emu.c:845: undefined reference to `card_emu_uart_update_wt'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libosmocore/include/osmocom/core/utils.h">File firmware/libosmocore/include/osmocom/core/utils.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/libosmocore/include/osmocom/core/utils.h@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace"> * \param[in] newstr String that will be copied to newly allocated string */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unrelated spelling fixes, should go in separate commit.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/23620">change 23620</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/23620"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibcb2c8cace9137695adf5fb3de43566f7cfb93b5 </div>
<div style="display:none"> Gerrit-Change-Number: 23620 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 04 Apr 2021 18:16:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>