Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 4 16:19:25 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 )

Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/7/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/7/src/osmo-bsc/bsc_vty.c@2752 
PS7, Line 2752: DEFUN_USRATTR
> Indeed, you cannot use a global command attribute as a user-/library-defined one. […]
we could probably assign different numeric ranges (like use some MSBs to distinguish the enum types, and the LSBs for the enum member) and then have some compile-time comparisons in the macro, something like a static_assert() that validates the enum member falls within the permitted range of that enum.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
Gerrit-Change-Number: 23574
Gerrit-PatchSet: 8
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 04 Apr 2021 16:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/66e59015/attachment.htm>


More information about the gerrit-log mailing list