Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

fixeria gerrit-no-reply at lists.osmocom.org
Sun Apr 4 13:55:30 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 )

Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

I fixed it, LGTM.

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/7/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/7/src/osmo-bsc/bsc_vty.c@2752 
PS7, Line 2752: DEFUN_USRATTR
> This muts be DEFUN_ATTR() if you use a global (libosmocore defined) attribute like CMD_ATTR_IMMEDIAT […]
Indeed, you cannot use a global command attribute as a user-/library-defined one. There are examples of using CMD_ATTR_IMMEDIATE in this file. This situation actually uncovers an interesting problem: one can mix different enum members and it will compile. Not sure if we can guard against this :/



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
Gerrit-Change-Number: 23574
Gerrit-PatchSet: 8
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 04 Apr 2021 13:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/a8a94abb/attachment.htm>


More information about the gerrit-log mailing list