Change in libosmocore[master]: add osmo_bts_features_names: short BTS feature strings

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 2 21:58:45 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23587 )

Change subject: add osmo_bts_features_names: short BTS feature strings
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23587/3/src/gsm/bts_features.c 
File src/gsm/bts_features.c:

https://gerrit.osmocom.org/c/libosmocore/+/23587/3/src/gsm/bts_features.c@52 
PS3, Line 52: osmo_bts_feature_name
So now we have:

  osmo_bts_features_name, and
  osmo_bts_feature_name.

Of course, the first symbol should have been called osmo_bts_features_desc(), but we can't change this. The new symbol name makes the situation even worse, and it's not obvious what is what for the API user. What about osmo_bts_feature_short_name() or osmo_bts_feature_name_short() instead?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I699cd27512887d64d824be680303e70fff3677c1
Gerrit-Change-Number: 23587
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/bed1d698/attachment.htm>


More information about the gerrit-log mailing list