<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23587">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23587/3/src/gsm/bts_features.c">File src/gsm/bts_features.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/23587/3/src/gsm/bts_features.c@52">Patch Set #3, Line 52:</a> <code style="font-family:monospace,monospace">osmo_bts_feature_name</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So now we have:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  osmo_bts_features_name, and<br>  osmo_bts_feature_name.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Of course, the first symbol should have been called osmo_bts_features_desc(), but we can't change this. The new symbol name makes the situation even worse, and it's not obvious what is what for the API user. What about osmo_bts_feature_short_name() or osmo_bts_feature_name_short() instead?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23587">change 23587</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23587"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I699cd27512887d64d824be680303e70fff3677c1 </div>
<div style="display:none"> Gerrit-Change-Number: 23587 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 02 Apr 2021 21:58:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>