Change in pysim[master]: ts_31_102: do not add empty ShellCommands class.

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 14:33:24 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23534 )

Change subject: ts_31_102: do not add empty ShellCommands class.
......................................................................

ts_31_102: do not add empty ShellCommands class.

The class ShellCommands defined in ADF_USIM overloads useful CommandSet
classes defined in the superclass, making their commands inaccessible.
Also ts_31_102 does not have such a class definition in the ADF_ISIM
class, so lets remove this class.

Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3
Related: OS#4963
---
M pySim/ts_31_102.py
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 54fd95d..9febaf7 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -486,7 +486,6 @@
     def __init__(self, aid='a0000000871002', name='ADF.USIM', fid=None, sfid=None,
                  desc='USIM Application'):
         super().__init__(aid=aid, fid=fid, sfid=sfid, name=name, desc=desc)
-        self.shell_commands = [self.ShellCommands()]
 
         files = [
           EF_LI(sfid=0x02),
@@ -518,12 +517,6 @@
     def decode_select_response(self, data_hex):
         return pySim.ts_102_221.decode_select_response(data_hex)
 
-    @with_default_category('File-Specific Commands')
-    class ShellCommands(CommandSet):
-        def __init__(self):
-            super().__init__()
-
-
 # TS 31.102 Section 7.3
 sw_usim = {
     'Security management': {

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3
Gerrit-Change-Number: 23534
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/dc03130d/attachment.htm>


More information about the gerrit-log mailing list