<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/23534">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ts_31_102: do not add empty ShellCommands class.<br><br>The class ShellCommands defined in ADF_USIM overloads useful CommandSet<br>classes defined in the superclass, making their commands inaccessible.<br>Also ts_31_102 does not have such a class definition in the ADF_ISIM<br>class, so lets remove this class.<br><br>Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3<br>Related: OS#4963<br>---<br>M pySim/ts_31_102.py<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py</span><br><span>index 54fd95d..9febaf7 100644</span><br><span>--- a/pySim/ts_31_102.py</span><br><span>+++ b/pySim/ts_31_102.py</span><br><span>@@ -486,7 +486,6 @@</span><br><span>     def __init__(self, aid='a0000000871002', name='ADF.USIM', fid=None, sfid=None,</span><br><span>                  desc='USIM Application'):</span><br><span>         super().__init__(aid=aid, fid=fid, sfid=sfid, name=name, desc=desc)</span><br><span style="color: hsl(0, 100%, 40%);">-        self.shell_commands = [self.ShellCommands()]</span><br><span> </span><br><span>         files = [</span><br><span>           EF_LI(sfid=0x02),</span><br><span>@@ -518,12 +517,6 @@</span><br><span>     def decode_select_response(self, data_hex):</span><br><span>         return pySim.ts_102_221.decode_select_response(data_hex)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    @with_default_category('File-Specific Commands')</span><br><span style="color: hsl(0, 100%, 40%);">-    class ShellCommands(CommandSet):</span><br><span style="color: hsl(0, 100%, 40%);">-        def __init__(self):</span><br><span style="color: hsl(0, 100%, 40%);">-            super().__init__()</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> # TS 31.102 Section 7.3</span><br><span> sw_usim = {</span><br><span>     'Security management': {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23534">change 23534</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23534"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3 </div>
<div style="display:none"> Gerrit-Change-Number: 23534 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>