Change in pysim[master]: Add decoder/encoder for EF.SUCI_Calc_Info

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 11:54:23 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23564 )

Change subject: Add decoder/encoder for EF.SUCI_Calc_Info
......................................................................


Patch Set 2:

(1 comment)

one more detai;

https://gerrit.osmocom.org/c/pysim/+/23564/2/pySim/ts_31_102.py 
File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/23564/2/pySim/ts_31_102.py@279 
PS2, Line 279: 	def __init__(self, fid="4f07", sfid=0x07, name='EF.SUCI_Calc_Info', size={2, None},
please note this file uses '4 spaces' indent, while your new code all uses tab-indent.   I know it's sort-of weird that different files in pySim use different indent, and that needs to be cleaned up.  Hoewevre, I think it's best to keep the indent within a file consistent.

Other than that, I would merge your patch for now, and then resolve the tlv bits iteratively once we settle on some general new TLV parser for all of the code.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac
Gerrit-Change-Number: 23564
Gerrit-PatchSet: 2
Gerrit-Owner: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Apr 2021 11:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/f889fd6e/attachment.htm>


More information about the gerrit-log mailing list