Change in pysim[master]: Add decoder/encoder for EF.SUCI_Calc_Info

merlinchlosta gerrit-no-reply at lists.osmocom.org
Fri Apr 2 09:51:13 UTC 2021


merlinchlosta has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23564 )

Change subject: Add decoder/encoder for EF.SUCI_Calc_Info
......................................................................


Patch Set 2:

(2 comments)

thanks for the feedback, i re-arranged the test vectors a bit, but kept the manual TLV hacking for now.

https://gerrit.osmocom.org/c/pysim/+/23564/1/pySim/ts_31_102.py 
File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/23564/1/pySim/ts_31_102.py@301 
PS1, Line 301: 			out_bytes.append(0x01) # TODO size, fixed to 1 byte
> this manual TLV encoding/decoding works, but is of course quite a bit of a hack. […]
i agree, i'll observe the TLV discussion. not planning to work on other features right now, just had to get my modem unstuck :)

my quick uttlv-experiments failed at this exact point, because uttlv wouldn't encode/decode an array of TLVs with the same identifier (like here: 0x80 for all keys in hnet_pubkey_list).


https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py 
File tests/test_utils.py:

https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py@95 
PS1, Line 95: 0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1
> I would move this and the other key into separate [class] variables, so there would be no need to re […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac
Gerrit-Change-Number: 23564
Gerrit-PatchSet: 2
Gerrit-Owner: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Apr 2021 09:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/8d063cd2/attachment.htm>


More information about the gerrit-log mailing list