Change in pysim[master]: pySim-shell: automatic ADM pin from CSV-File

dexter gerrit-no-reply at lists.osmocom.org
Thu Apr 1 15:44:55 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23538 )

Change subject: pySim-shell: automatic ADM pin from CSV-File
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py@368 
PS1, Line 368: 	csv_
> I would go for something like ~/.osmocom/pysim/card_data.csv […]
Done


https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim-shell.py@372 
PS1, Line 372: 		card_data_register(CardDataCsv(csv_default))
> they might not be exclusive-or.  You could register them in the order that the opts. […]
Done


https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py 
File pySim/card_data.py:

https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py@33 
PS1, Line 33: 		"""abstract implementation of gst_data that only verifies the function parameters"""
> get_data
Done


https://gerrit.osmocom.org/c/pysim/+/23538/1/pySim/card_data.py@70 
PS1, Line 70: 		if not cr:
> This way you open, read, parse and search the CSV file on every get(). […]
As far as I remember there were problems. I believe it was the CSV DictReader which can not jump to the beginning of the file again. I will keep it like this. Also reading all at once into memory has disadvantage. It would not be possible to update/edit the CSV without restarting pysim.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I51835ccb16bcbce35e7f3765e8927a4451509e77
Gerrit-Change-Number: 23538
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 15:44:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/325be8dc/attachment.htm>


More information about the gerrit-log mailing list