Change in pysim[master]: pySim-shell: automatic ADM pin from CSV-File

dexter gerrit-no-reply at lists.osmocom.org
Thu Apr 1 15:34:05 UTC 2021


Hello Jenkins Builder, pespin, daniel, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/pysim/+/23538

to look at the new patch set (#3).

Change subject: pySim-shell: automatic ADM pin from CSV-File
......................................................................

pySim-shell: automatic ADM pin from CSV-File

It can be hard to manage ADM pins when working with different cards at
the same time. To make this easier, add an automatic way to determine
the ADM pin for each card from a CSV file.

- add a CardData clas model that can be extended to to get the data from
  various different sources. For now use CSV-Files. Also add a way how
  multiple CardData classes can be registered so that one global get
  function can query all registered CardData classes at once.

- automatically check for CSV-File in home directory and use it as
  default CardData source unless the user specifies a CSV file via
  commandline argument.

- extend the verify_adm command so that it automatically queries the
  ADM pin if no argument is given. Also do not try to authenticate if
  no ADM pin could be determined.

Change-Id: I51835ccb16bcbce35e7f3765e8927a4451509e77
Related: OS#4963
---
M pySim-shell.py
A pySim/card_data.py
2 files changed, 146 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/23538/3
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I51835ccb16bcbce35e7f3765e8927a4451509e77
Gerrit-Change-Number: 23538
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/91aa76a5/attachment.htm>


More information about the gerrit-log mailing list