Change in osmo-mgw[master]: mgcp_vty: add missing VTY commands for E1 trunks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Nov 27 19:39:57 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/21364 )

Change subject: mgcp_vty: add missing VTY commands for E1 trunks
......................................................................

mgcp_vty: add missing VTY commands for E1 trunks

The E1 trunk lacks the VTY commands force-realloc and rtp-accept-all.
However, the function that write the E1 trunk config includes those
commands. Also they would be applicable, so lets add those two commands
also for E1 trunks.

Change-Id: Ief2bc7502bb8d1e0f9c784d42edbe1aed5ffb728
---
M src/libosmo-mgcp/mgcp_vty.c
1 file changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c
index 681ca99..9ad8c24 100644
--- a/src/libosmo-mgcp/mgcp_vty.c
+++ b/src/libosmo-mgcp/mgcp_vty.c
@@ -1056,6 +1056,32 @@
 	return CMD_SUCCESS;
 }
 
+DEFUN_USRATTR(cfg_trunk_force_realloc,
+	      cfg_trunk_force_realloc_cmd,
+	      X(MGW_CMD_ATTR_NEWCONN),
+	      "force-realloc (0|1)",
+	      "Force endpoint reallocation when the endpoint is still seized\n"
+	      "Don't force reallocation\n" "force reallocation\n")
+{
+	struct mgcp_trunk *trunk = vty->index;
+	OSMO_ASSERT(trunk);
+	trunk->force_realloc = atoi(argv[0]);
+	return CMD_SUCCESS;
+}
+
+DEFUN_ATTR(cfg_trunk_rtp_accept_all,
+	   cfg_trunk_rtp_accept_all_cmd,
+	   "rtp-accept-all (0|1)",
+	   "Accept all RTP packets, even when the originating IP/Port does not match\n"
+	   "enable filter\n" "disable filter\n",
+	   CMD_ATTR_IMMEDIATE)
+{
+	struct mgcp_trunk *trunk = vty->index;
+	OSMO_ASSERT(trunk);
+	trunk->rtp_accept_all = atoi(argv[0]);
+	return CMD_SUCCESS;
+}
+
 DEFUN_USRATTR(cfg_trunk_sdp_payload_send_ptime,
 	      cfg_trunk_sdp_payload_send_ptime_cmd,
 	      X(MGW_CMD_ATTR_NEWCONN),
@@ -1647,6 +1673,8 @@
 	install_element(TRUNK_NODE, &cfg_trunk_payload_number_cmd_old);
 	install_element(TRUNK_NODE, &cfg_trunk_payload_name_cmd_old);
 	install_element(TRUNK_NODE, &cfg_trunk_loop_cmd);
+	install_element(TRUNK_NODE, &cfg_trunk_force_realloc_cmd);
+	install_element(TRUNK_NODE, &cfg_trunk_rtp_accept_all_cmd);
 	install_element(TRUNK_NODE, &cfg_trunk_omit_rtcp_cmd);
 	install_element(TRUNK_NODE, &cfg_trunk_no_omit_rtcp_cmd);
 	install_element(TRUNK_NODE, &cfg_trunk_patch_rtp_ssrc_cmd);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/21364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ief2bc7502bb8d1e0f9c784d42edbe1aed5ffb728
Gerrit-Change-Number: 21364
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201127/fa1910a9/attachment.htm>


More information about the gerrit-log mailing list