<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/21364">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_vty: add missing VTY commands for E1 trunks<br><br>The E1 trunk lacks the VTY commands force-realloc and rtp-accept-all.<br>However, the function that write the E1 trunk config includes those<br>commands. Also they would be applicable, so lets add those two commands<br>also for E1 trunks.<br><br>Change-Id: Ief2bc7502bb8d1e0f9c784d42edbe1aed5ffb728<br>---<br>M src/libosmo-mgcp/mgcp_vty.c<br>1 file changed, 28 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>index 681ca99..9ad8c24 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_vty.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_vty.c</span><br><span>@@ -1056,6 +1056,32 @@</span><br><span>        return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_trunk_force_realloc,</span><br><span style="color: hsl(120, 100%, 40%);">+        cfg_trunk_force_realloc_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+          X(MGW_CMD_ATTR_NEWCONN),</span><br><span style="color: hsl(120, 100%, 40%);">+              "force-realloc (0|1)",</span><br><span style="color: hsl(120, 100%, 40%);">+              "Force endpoint reallocation when the endpoint is still seized\n"</span><br><span style="color: hsl(120, 100%, 40%);">+           "Don't force reallocation\n" "force reallocation\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct mgcp_trunk *trunk = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(trunk);</span><br><span style="color: hsl(120, 100%, 40%);">+   trunk->force_realloc = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+      return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_ATTR(cfg_trunk_rtp_accept_all,</span><br><span style="color: hsl(120, 100%, 40%);">+           cfg_trunk_rtp_accept_all_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+         "rtp-accept-all (0|1)",</span><br><span style="color: hsl(120, 100%, 40%);">+     "Accept all RTP packets, even when the originating IP/Port does not match\n"</span><br><span style="color: hsl(120, 100%, 40%);">+        "enable filter\n" "disable filter\n",</span><br><span style="color: hsl(120, 100%, 40%);">+     CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     struct mgcp_trunk *trunk = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(trunk);</span><br><span style="color: hsl(120, 100%, 40%);">+   trunk->rtp_accept_all = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+     return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN_USRATTR(cfg_trunk_sdp_payload_send_ptime,</span><br><span>        cfg_trunk_sdp_payload_send_ptime_cmd,</span><br><span>        X(MGW_CMD_ATTR_NEWCONN),</span><br><span>@@ -1647,6 +1673,8 @@</span><br><span>       install_element(TRUNK_NODE, &cfg_trunk_payload_number_cmd_old);</span><br><span>  install_element(TRUNK_NODE, &cfg_trunk_payload_name_cmd_old);</span><br><span>    install_element(TRUNK_NODE, &cfg_trunk_loop_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(TRUNK_NODE, &cfg_trunk_force_realloc_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+        install_element(TRUNK_NODE, &cfg_trunk_rtp_accept_all_cmd);</span><br><span>      install_element(TRUNK_NODE, &cfg_trunk_omit_rtcp_cmd);</span><br><span>   install_element(TRUNK_NODE, &cfg_trunk_no_omit_rtcp_cmd);</span><br><span>        install_element(TRUNK_NODE, &cfg_trunk_patch_rtp_ssrc_cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/21364">change 21364</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/21364"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ief2bc7502bb8d1e0f9c784d42edbe1aed5ffb728 </div>
<div style="display:none"> Gerrit-Change-Number: 21364 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>