Change in osmo-bsc[master]: hodec 2: favor moving dyn TS

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21204 )

Change subject: hodec 2: favor moving dyn TS
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG@23 
PS4, Line 23: Among lchans on dynamic timeslots that could be moved, this code favors moving
            : later lchans; mainly because it makes for a simpler condition in the code.
here


https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4/src/osmo-bsc/handover_decision_2.c 
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4/src/osmo-bsc/handover_decision_2.c@1576 
PS4, Line 1576: 			best_cand = &clist[i];
> I don't know the details here, but maybe you also need to check that the current TS is not a dynamic […]
the commit log has the rationale for why that isn't needed.

Initially I also thought it would be in fact better to favor moving later dyn TS, for configurations where a static PDCH follows a set of dyn TS. I didn't write that in the commit log because
a) I'm not completely sure having consecutive PDCH is improving GPRS service.
b) handover_test 30 shows that it doesn't necessarily help defragmenting PDCH.
c) of course the argument only makes sense for configs where PDCH follow dyn TS, up to the user.

So the only remaining argument is that having less terms in the if condition is less code.
It is definitely in no way harmful to pick a later dyn TS over an earlier one.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21204
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic221b8d2687cdec0bf94410c84a4da43853f0900
Gerrit-Change-Number: 21204
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Nov 2020 16:39:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/1ff6af60/attachment.htm>