This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21047 ) Change subject: tdef: Introduce OSMO_TDEF_US unit ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/21047/1/tests/tdef/tdef_test.c File tests/tdef/tdef_test.c: https://gerrit.osmocom.org/c/libosmocore/+/21047/1/tests/tdef/tdef_test.c@57 PS1, Line 57: { .T=1009, .default_val=0, .unit=OSMO_TDEF_US, .desc="zero" }, > Add unit, so desc="zero us" in line with T1004/5/6/7 above Ack https://gerrit.osmocom.org/c/libosmocore/+/21047/1/tests/tdef/tdef_test.c@115 PS1, Line 115: for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++) { > Maybe nicer to have a comparison < OSMO_TDEF_MAX and always keep that last in the enum? The we can't […] That would mean having a public symbol which would change its value when a new one is added, so not sure if it would make stuff better or not. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71848d7c1ee0649929ce07680ee7320bb2a42f0e Gerrit-Change-Number: 21047 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 09 Nov 2020 11:55:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/0477f853/attachment.htm>