Change in libosmocore[master]: tdef: Introduce OSMO_TDEF_US unit

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21047 )

Change subject: tdef: Introduce OSMO_TDEF_US unit
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21047/1/tests/tdef/tdef_test.c 
File tests/tdef/tdef_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/21047/1/tests/tdef/tdef_test.c@115 
PS1, Line 115: 		for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++) {
> That would mean having a public symbol which would change its value when a new one is added, so not  […]
I was going to bring up OSMO_NUM_DLIB, but that uses defines instead of an enum.

On second thought I don't think we have much of a use case for looping through the unit enum anyway outside of the tests, do we? So probably just leave as is.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I71848d7c1ee0649929ce07680ee7320bb2a42f0e
Gerrit-Change-Number: 21047
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Nov 2020 15:08:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/3716171e/attachment.htm>