This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21073 ) Change subject: TLLI 0x00000000 is a valid TLLI, use 0xffffffff instead ...................................................................... TLLI 0x00000000 is a valid TLLI, use 0xffffffff instead The assumption that TLLI 0x00000000 is invalid and can be used as the initializer is wrong. Similar to TMSI, 0x00000000 is a perfectly valid value, while 0xffffffff is reserved - use it. I manually checked and corrected all occurances of 'tlli' in the code. The test expectations have been adjusted with this command: $ find tests/ -name "*.err" | xargs sed -i "s/0x00000000/0xffffffff/g" so there should be no behavior change. The only exception is the 'TypesTest', where TLLI 0xffffffff is being encoded and expected in the hexdump, so I regenerated the test output. Change-Id: Ie89fab75ecc1d8b5e238d3ff214ea7ac830b68b5 Related: OS#4844 --- M src/bts.h M src/gprs_bssgp_pcu.cpp M src/gprs_ms.cpp M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/gprs_ms_storage.h M src/tbf.cpp M src/tbf.h M src/tbf_ul.cpp M tests/alloc/AllocTest.err M tests/app_info/AppInfoTest.err M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/types/TypesTest.err M tests/types/TypesTest.ok 16 files changed, 196,750 insertions(+), 196,741 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/73/21073/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie89fab75ecc1d8b5e238d3ff214ea7ac830b68b5 Gerrit-Change-Number: 21073 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201108/e0572d23/attachment.htm>