This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21073 ) Change subject: TLLI 0x00000000 is a valid TLLI, use 0xffffffff instead ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1//COMMIT_MSG@20 PS1, Line 20: expected in the hexdump, so I regenerated the test output. > I miss a spec reference here where TLLI 0xffffff is specified as invalid. Done https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/gprs_ms.h File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/gprs_ms.h@215 PS1, Line 215: else if (m_tlli != GSM_RESERVED_TMSI) > these else are not needed (early return) and only make following code more difficult to follow. I see no difference, but ok. https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/tbf.cpp@172 PS1, Line 172: uint32_t gprs_rlcmac_tbf::tlli() const > We should simply drop this function and use the ms one directly. […] Ack https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21073/1/src/tbf_ul.cpp@459 PS1, Line 459: "TLLI is 0xffffffff within UL DATA?!?\n"); > print the 0xfff using "0x%08x" GSM_RESERVED_TMSI ? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie89fab75ecc1d8b5e238d3ff214ea7ac830b68b5 Gerrit-Change-Number: 21073 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 10 Nov 2020 12:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201110/fc9f4337/attachment.htm>