Change in osmo-bts[master]: main: do not print asciiart to stdout, use stderr instead

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20953 )

Change subject: main: do not print asciiart to stdout, use stderr instead
......................................................................

main: do not print asciiart to stdout, use stderr instead

Otherwise it ends up in the generated XML VTY reference:

  $ head doc/manuals/vty/bts_trx_vty_reference.xml
    ((*))
      |
     / \ OsmoBTS
    <vtydoc xmlns='urn:osmocom:xml:libosmocore:vty:doc:1.0'>
      <node id='_common_cmds_'>
        <name>Common Commands</name>

Also, take a chance to move it below handle_options(), so it
will only be printed if all arguments are parsed successfully.

Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510
Related: SYS#4937, OS#3036
---
M src/common/main.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/main.c b/src/common/main.c
index 102bf88..b2534d5 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -264,8 +264,6 @@
 	struct e1inp_line *line;
 	int rc;
 
-	printf("((*))\n  |\n / \\ OsmoBTS\n");
-
 	/* Track the use of talloc NULL memory contexts */
 	talloc_enable_null_tracking();
 
@@ -289,6 +287,8 @@
 
 	handle_options(argc, argv);
 
+	fprintf(stderr, "((*))\n  |\n / \\ OsmoBTS\n");
+
 	g_bts = gsm_bts_alloc(tall_bts_ctx, 0);
 	if (!g_bts) {
 		fprintf(stderr, "Failed to create BTS structure\n");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20953
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510
Gerrit-Change-Number: 20953
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/9b78e9e1/attachment.htm>