<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20953">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">main: do not print asciiart to stdout, use stderr instead<br><br>Otherwise it ends up in the generated XML VTY reference:<br><br> $ head doc/manuals/vty/bts_trx_vty_reference.xml<br> ((*))<br> |<br> / \ OsmoBTS<br> <vtydoc xmlns='urn:osmocom:xml:libosmocore:vty:doc:1.0'><br> <node id='_common_cmds_'><br> <name>Common Commands</name><br><br>Also, take a chance to move it below handle_options(), so it<br>will only be printed if all arguments are parsed successfully.<br><br>Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510<br>Related: SYS#4937, OS#3036<br>---<br>M src/common/main.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/main.c b/src/common/main.c</span><br><span>index 102bf88..b2534d5 100644</span><br><span>--- a/src/common/main.c</span><br><span>+++ b/src/common/main.c</span><br><span>@@ -264,8 +264,6 @@</span><br><span> struct e1inp_line *line;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("((*))\n |\n / \\ OsmoBTS\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Track the use of talloc NULL memory contexts */</span><br><span> talloc_enable_null_tracking();</span><br><span> </span><br><span>@@ -289,6 +287,8 @@</span><br><span> </span><br><span> handle_options(argc, argv);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "((*))\n |\n / \\ OsmoBTS\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> g_bts = gsm_bts_alloc(tall_bts_ctx, 0);</span><br><span> if (!g_bts) {</span><br><span> fprintf(stderr, "Failed to create BTS structure\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20953">change 20953</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20953"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510 </div>
<div style="display:none"> Gerrit-Change-Number: 20953 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>