Change in osmo-sgsn[master]: gbproxy_test.c: fix mobile identity test data

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/18585 )


Change subject: gbproxy_test.c: fix mobile identity test data
......................................................................

gbproxy_test.c: fix mobile identity test data

Fix the final nibble of all IMSI BCD digits to 0xf, since it is a filler digit.

The encoded IMSI has an even amount of digits (14) and must contain a 0xf
filler nibble at the end. The test data looked correct due to repeated '1'
digits.

wrong hex: 11 12 13 14 15 16 17 18
correct:   11 12 13 14 15 16 17 f8
order:     1T 32 54 76 98 ba dc Xe  T = type, X = filler, 1..e = 14 digits

This error was found when applying the new osmo_mobile_identity API.

Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9
---
M tests/gbproxy/gbproxy_test.c
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/85/18585/1

diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c
index f5c730d..95989f0 100644
--- a/tests/gbproxy/gbproxy_test.c
+++ b/tests/gbproxy/gbproxy_test.c
@@ -260,7 +260,7 @@
 static const unsigned char dtap_attach_req4[] = {
 	0x08, 0x01, 0x02, 0xf5, 0xe0, 0x21, 0x08, 0x02,
 	0x08, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
-	0x18, 0x11, 0x22, 0x33, 0x40, 0x50, 0x60, 0x19,
+	0xf8, 0x11, 0x22, 0x33, 0x40, 0x50, 0x60, 0x19,
 	0x18, 0xb3, 0x43, 0x2b, 0x25, 0x96, 0x62, 0x00,
 	0x60, 0x80, 0x9a, 0xc2, 0xc6, 0x62, 0x00, 0x60,
 	0x80, 0xba, 0xc8, 0xc6, 0x62, 0x00, 0x60, 0x80,
@@ -275,7 +275,7 @@
 /* DTAP - Identity Response */
 static const unsigned char dtap_identity_resp[] = {
 	0x08, 0x16, 0x08, 0x11, 0x12, 0x13, 0x14, 0x15,
-	0x16, 0x17, 0x18
+	0x16, 0x17, 0xf8
 };
 
 /* DTAP - Identity Response, IMSI 2 */
@@ -1650,7 +1650,7 @@
 	const uint32_t local_tlli = 0xefe2b700;
 	const uint32_t foreign_tlli = 0xbbc54679;
 	const uint32_t foreign_tlli2 = 0xbb00beef;
-	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
+	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
 	const char *patch_re = "^9898|^121314";
 	struct gbproxy_link_info *link_info;
 	struct gbproxy_peer *peer;
@@ -1992,8 +1992,8 @@
 	const uint32_t foreign_tlli1 = 0x8000dead;
 	const uint32_t foreign_tlli2 = 0x8000beef;
 
-	const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
-	const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0x18};
+	const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
+	const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0xf8};
 
 	struct gbproxy_link_info *link_info, *link_info2;
 	struct gbproxy_peer *peer;
@@ -2224,7 +2224,7 @@
 	const uint32_t foreign_bss_tlli = 0x8000dead;
 
 
-	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
+	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
 	struct gbproxy_link_info *link_info;
 	struct gbproxy_peer *peer;
 	unsigned bss_nu = 0;
@@ -2550,7 +2550,7 @@
 	const uint32_t foreign_bss_tlli = 0x8000dead;
 
 
-	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
+	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
 	struct gbproxy_link_info *link_info;
 	struct gbproxy_peer *peer;
 	unsigned bss_nu = 0;
@@ -2737,7 +2737,7 @@
 	const uint32_t foreign_bss_tlli = 0x8000dead;
 	const uint32_t other_bss_tlli = 0x8000beef;
 
-	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
+	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
 	struct gbproxy_link_info *link_info;
 	struct gbproxy_peer *peer;
 	unsigned bss_nu = 0;
@@ -3058,9 +3058,9 @@
 	const uint32_t local_bss_tlli3 = 0xc0dead05;
 	const uint32_t foreign_bss_tlli3 = 0x8000feed;
 
-	const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
-	const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0x18};
-	const uint8_t imsi3[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x26, 0x27, 0x28};
+	const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
+	const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0xf8};
+	const uint8_t imsi3[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x26, 0x27, 0xf8};
 	struct gbproxy_link_info *link_info;
 	struct gbproxy_link_info *other_info;
 	struct gbproxy_peer *peer;
@@ -3542,7 +3542,7 @@
 	const uint32_t local_tlli = 0xefe2b700;
 	const uint32_t foreign_tlli = 0xafe2b700;
 
-	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};
+	const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};
 	struct gbproxy_link_info *link_info, *link_info2;
 	struct gbproxy_peer *peer;
 	unsigned bss_nu = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/18585
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/e6f2c76f/attachment.htm>