<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18585">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy_test.c: fix mobile identity test data<br><br>Fix the final nibble of all IMSI BCD digits to 0xf, since it is a filler digit.<br><br>The encoded IMSI has an even amount of digits (14) and must contain a 0xf<br>filler nibble at the end. The test data looked correct due to repeated '1'<br>digits.<br><br>wrong hex: 11 12 13 14 15 16 17 18<br>correct: 11 12 13 14 15 16 17 f8<br>order: 1T 32 54 76 98 ba dc Xe T = type, X = filler, 1..e = 14 digits<br><br>This error was found when applying the new osmo_mobile_identity API.<br><br>Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9<br>---<br>M tests/gbproxy/gbproxy_test.c<br>1 file changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/85/18585/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c</span><br><span>index f5c730d..95989f0 100644</span><br><span>--- a/tests/gbproxy/gbproxy_test.c</span><br><span>+++ b/tests/gbproxy/gbproxy_test.c</span><br><span>@@ -260,7 +260,7 @@</span><br><span> static const unsigned char dtap_attach_req4[] = {</span><br><span> 0x08, 0x01, 0x02, 0xf5, 0xe0, 0x21, 0x08, 0x02,</span><br><span> 0x08, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x18, 0x11, 0x22, 0x33, 0x40, 0x50, 0x60, 0x19,</span><br><span style="color: hsl(120, 100%, 40%);">+ 0xf8, 0x11, 0x22, 0x33, 0x40, 0x50, 0x60, 0x19,</span><br><span> 0x18, 0xb3, 0x43, 0x2b, 0x25, 0x96, 0x62, 0x00,</span><br><span> 0x60, 0x80, 0x9a, 0xc2, 0xc6, 0x62, 0x00, 0x60,</span><br><span> 0x80, 0xba, 0xc8, 0xc6, 0x62, 0x00, 0x60, 0x80,</span><br><span>@@ -275,7 +275,7 @@</span><br><span> /* DTAP - Identity Response */</span><br><span> static const unsigned char dtap_identity_resp[] = {</span><br><span> 0x08, 0x16, 0x08, 0x11, 0x12, 0x13, 0x14, 0x15,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x16, 0x17, 0x18</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x16, 0x17, 0xf8</span><br><span> };</span><br><span> </span><br><span> /* DTAP - Identity Response, IMSI 2 */</span><br><span>@@ -1650,7 +1650,7 @@</span><br><span> const uint32_t local_tlli = 0xefe2b700;</span><br><span> const uint32_t foreign_tlli = 0xbbc54679;</span><br><span> const uint32_t foreign_tlli2 = 0xbb00beef;</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span> const char *patch_re = "^9898|^121314";</span><br><span> struct gbproxy_link_info *link_info;</span><br><span> struct gbproxy_peer *peer;</span><br><span>@@ -1992,8 +1992,8 @@</span><br><span> const uint32_t foreign_tlli1 = 0x8000dead;</span><br><span> const uint32_t foreign_tlli2 = 0x8000beef;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0xf8};</span><br><span> </span><br><span> struct gbproxy_link_info *link_info, *link_info2;</span><br><span> struct gbproxy_peer *peer;</span><br><span>@@ -2224,7 +2224,7 @@</span><br><span> const uint32_t foreign_bss_tlli = 0x8000dead;</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span> struct gbproxy_link_info *link_info;</span><br><span> struct gbproxy_peer *peer;</span><br><span> unsigned bss_nu = 0;</span><br><span>@@ -2550,7 +2550,7 @@</span><br><span> const uint32_t foreign_bss_tlli = 0x8000dead;</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span> struct gbproxy_link_info *link_info;</span><br><span> struct gbproxy_peer *peer;</span><br><span> unsigned bss_nu = 0;</span><br><span>@@ -2737,7 +2737,7 @@</span><br><span> const uint32_t foreign_bss_tlli = 0x8000dead;</span><br><span> const uint32_t other_bss_tlli = 0x8000beef;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span> struct gbproxy_link_info *link_info;</span><br><span> struct gbproxy_peer *peer;</span><br><span> unsigned bss_nu = 0;</span><br><span>@@ -3058,9 +3058,9 @@</span><br><span> const uint32_t local_bss_tlli3 = 0xc0dead05;</span><br><span> const uint32_t foreign_bss_tlli3 = 0x8000feed;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi3[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x26, 0x27, 0x28};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi1[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi2[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x16, 0x17, 0xf8};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi3[] = {0x11, 0x12, 0x99, 0x99, 0x99, 0x26, 0x27, 0xf8};</span><br><span> struct gbproxy_link_info *link_info;</span><br><span> struct gbproxy_link_info *other_info;</span><br><span> struct gbproxy_peer *peer;</span><br><span>@@ -3542,7 +3542,7 @@</span><br><span> const uint32_t local_tlli = 0xefe2b700;</span><br><span> const uint32_t foreign_tlli = 0xafe2b700;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18};</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t imsi[] = {0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0xf8};</span><br><span> struct gbproxy_link_info *link_info, *link_info2;</span><br><span> struct gbproxy_peer *peer;</span><br><span> unsigned bss_nu = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18585">change 18585</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/18585"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9 </div>
<div style="display:none"> Gerrit-Change-Number: 18585 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>