Change in osmo-bsc[master]: stats: Correctly count lchans under BORKEN/NOT_INITIALIZED TS.

[ipse]

ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18334 )

Change subject: stats: Correctly count lchans under BORKEN/NOT_INITIALIZED TS.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c 
File src/osmo-bsc/chan_alloc.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@72 
PS2, Line 72: 				pl->total++;
> here, avoid increasing total if ts is not available. […]
The whole idea of this if() is that the timeslots ARE available if they are in one of these configurations.


https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@89 
PS2, Line 89: 				
> whitespace
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@93 
PS2, Line 93: 				if (!ts_is_usable(ts)) {
> I think it makes sense to simply not increment pl->total above if this case is matched.
No, the logic here is the opposite. Borken lchans (children FSM of a TS FSM) are already counted as both total and used because they are most likely transient states due to A-bis link latency. But lchans in non-borken states which are children of broken TS were previously not counted as used which created artifacts in channel counting (I can show you screenshots if you want). This change synchronizes behavior between broken lchans which are children of non-broken TS wich non-broken lchans which are children of broken TS.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18334
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic3dbc6b176d5dcff7ed2589bb875abf93e9f7ab0
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 2
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 17 May 2020 20:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/88b9c325/attachment.htm>