This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18334 ) Change subject: stats: Correctly count lchans under BORKEN/NOT_INITIALIZED TS. ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c File src/osmo-bsc/chan_alloc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@72 PS2, Line 72: pl->total++; here, avoid increasing total if ts is not available. Or even above by calling continue; https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@89 PS2, Line 89: whitespace https://gerrit.osmocom.org/c/osmo-bsc/+/18334/2/src/osmo-bsc/chan_alloc.c@93 PS2, Line 93: if (!ts_is_usable(ts)) { I think it makes sense to simply not increment pl->total above if this case is matched. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic3dbc6b176d5dcff7ed2589bb875abf93e9f7ab0 Gerrit-Change-Number: 18334 Gerrit-PatchSet: 2 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 16 May 2020 22:34:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200516/c0602922/attachment.htm>