Change in osmo-pcu[master]: gprs_debug: Use only LOGL_NOTICE as default loglevel

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17609 )

Change subject: gprs_debug: Use only LOGL_NOTICE as default loglevel
......................................................................

gprs_debug: Use only LOGL_NOTICE as default loglevel

The default loglevels of some log categories are configured to
LOGL_INFO. This is still to verbose, lets use LOGL_NOTICE here.

Change-Id: Ibb1cd1a94fb4fdd0147e073f8c1c82562c2c14ef
Related: OS#2577
---
M src/gprs_debug.cpp
M tests/alloc/AllocTest.cpp
M tests/types/TypesTest.cpp
3 files changed, 12 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp
index 58b7e3e..da5974b 100644
--- a/src/gprs_debug.cpp
+++ b/src/gprs_debug.cpp
@@ -32,14 +32,14 @@
 		.name = "DCSN1",
 		.color = "\033[1;31m",
 		.description = "Concrete Syntax Notation One (CSN1)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 0,
 	},
 	[DL1IF] = {
 		.name = "DL1IF",
 		.color = "\033[1;32m",
 		.description = "GPRS PCU L1 interface (L1IF)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DRLCMAC] = {
@@ -81,42 +81,42 @@
 		.name = "DRLCMACMEAS",
 		.color = "\033[1;31m",
 		.description = "GPRS RLC/MAC layer Measurements (RLCMAC)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBF] = {
 		.name = "DTBF",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBFDL] = {
 		.name = "DTBFDL",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF) Downlink",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBFUL] = {
 		.name = "DTBFUL",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF) Uplink",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DNS] = {
 		.name = "DNS",
 		.color = "\033[1;34m",
 		.description = "GPRS Network Service Protocol (NS)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DBSSGP] = {
 		.name = "DBSSGP",
 		.color = "\033[1;34m",
 		.description = "GPRS BSS Gateway Protocol (BSSGP)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DPCU] = {
diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp
index fec2c31..8ebf159 100644
--- a/tests/alloc/AllocTest.cpp
+++ b/tests/alloc/AllocTest.cpp
@@ -809,6 +809,7 @@
 	osmo_init_logging2(tall_pcu_ctx, &gprs_log_info);
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_filename(osmo_stderr_target, 0);
+	log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);
 	if (getenv("LOGL_DEBUG"))
 		log_set_log_level(osmo_stderr_target, LOGL_DEBUG);
 
diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp
index e3c0991..b46a82b 100644
--- a/tests/types/TypesTest.cpp
+++ b/tests/types/TypesTest.cpp
@@ -915,6 +915,9 @@
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_filename(osmo_stderr_target, 0);
 
+	log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);
+	log_set_category_filter(osmo_stderr_target, DTBFUL, 1, LOGL_INFO);
+
 	printf("Making some basic type testing.\n");
 
 	test_llc();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibb1cd1a94fb4fdd0147e073f8c1c82562c2c14ef
Gerrit-Change-Number: 17609
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/ec0de0cb/attachment.htm>