<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17609">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_debug: Use only LOGL_NOTICE as default loglevel<br><br>The default loglevels of some log categories are configured to<br>LOGL_INFO. This is still to verbose, lets use LOGL_NOTICE here.<br><br>Change-Id: Ibb1cd1a94fb4fdd0147e073f8c1c82562c2c14ef<br>Related: OS#2577<br>---<br>M src/gprs_debug.cpp<br>M tests/alloc/AllocTest.cpp<br>M tests/types/TypesTest.cpp<br>3 files changed, 12 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp</span><br><span>index 58b7e3e..da5974b 100644</span><br><span>--- a/src/gprs_debug.cpp</span><br><span>+++ b/src/gprs_debug.cpp</span><br><span>@@ -32,14 +32,14 @@</span><br><span> .name = "DCSN1",</span><br><span> .color = "\033[1;31m",</span><br><span> .description = "Concrete Syntax Notation One (CSN1)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 0,</span><br><span> },</span><br><span> [DL1IF] = {</span><br><span> .name = "DL1IF",</span><br><span> .color = "\033[1;32m",</span><br><span> .description = "GPRS PCU L1 interface (L1IF)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DRLCMAC] = {</span><br><span>@@ -81,42 +81,42 @@</span><br><span> .name = "DRLCMACMEAS",</span><br><span> .color = "\033[1;31m",</span><br><span> .description = "GPRS RLC/MAC layer Measurements (RLCMAC)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DTBF] = {</span><br><span> .name = "DTBF",</span><br><span> .color = "\033[1;34m",</span><br><span> .description = "Temporary Block Flow (TBF)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DTBFDL] = {</span><br><span> .name = "DTBFDL",</span><br><span> .color = "\033[1;34m",</span><br><span> .description = "Temporary Block Flow (TBF) Downlink",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DTBFUL] = {</span><br><span> .name = "DTBFUL",</span><br><span> .color = "\033[1;34m",</span><br><span> .description = "Temporary Block Flow (TBF) Uplink",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DNS] = {</span><br><span> .name = "DNS",</span><br><span> .color = "\033[1;34m",</span><br><span> .description = "GPRS Network Service Protocol (NS)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DBSSGP] = {</span><br><span> .name = "DBSSGP",</span><br><span> .color = "\033[1;34m",</span><br><span> .description = "GPRS BSS Gateway Protocol (BSSGP)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DPCU] = {</span><br><span>diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp</span><br><span>index fec2c31..8ebf159 100644</span><br><span>--- a/tests/alloc/AllocTest.cpp</span><br><span>+++ b/tests/alloc/AllocTest.cpp</span><br><span>@@ -809,6 +809,7 @@</span><br><span> osmo_init_logging2(tall_pcu_ctx, &gprs_log_info);</span><br><span> log_set_use_color(osmo_stderr_target, 0);</span><br><span> log_set_print_filename(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);</span><br><span> if (getenv("LOGL_DEBUG"))</span><br><span> log_set_log_level(osmo_stderr_target, LOGL_DEBUG);</span><br><span> </span><br><span>diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp</span><br><span>index e3c0991..b46a82b 100644</span><br><span>--- a/tests/types/TypesTest.cpp</span><br><span>+++ b/tests/types/TypesTest.cpp</span><br><span>@@ -915,6 +915,9 @@</span><br><span> log_set_use_color(osmo_stderr_target, 0);</span><br><span> log_set_print_filename(osmo_stderr_target, 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);</span><br><span style="color: hsl(120, 100%, 40%);">+ log_set_category_filter(osmo_stderr_target, DTBFUL, 1, LOGL_INFO);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> printf("Making some basic type testing.\n");</span><br><span> </span><br><span> test_llc();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17609">change 17609</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17609"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibb1cd1a94fb4fdd0147e073f8c1c82562c2c14ef </div>
<div style="display:none"> Gerrit-Change-Number: 17609 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>