Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/mncc-python/+/17980 )

Change subject: mncc_mt_loadgen.py: add codec arg
......................................................................

mncc_mt_loadgen.py: add codec arg

Add codec parameter to start_call() and convenience functions mt_call()
and calls() with FR as default. While at it, update the help text.

Related: SYS#4924
Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
---
M mncc_mt_loadgen.py
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  osmith: Verified
  laforge: Looks good to me, approved



diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py
index 5f15e3b..e401fcb 100755
--- a/mncc_mt_loadgen.py
+++ b/mncc_mt_loadgen.py
@@ -109,12 +109,11 @@
         self.state = 'NULL'
         self.rtp_msc = None
 
-    def start_call(self, msisdn_called, msisdn_calling):
+    def start_call(self, msisdn_called, msisdn_calling, codec):
         '''Start a MT call from given [external] calling party to given mobile party MSISDN'''
         self.msisdn_called = msisdn_called
         self.msisdn_calling = msisdn_calling
         # allocate a RTP connection @ rtpsource
-        codec = "GSM_FR"  # FIXME: make configurable
         r = self.ctrl_act.ask({'type':'rtp_create', 'cname':self.callref, 'codec':codec})
         self.ext_rtp_host = r['remote_host']
         self.ext_rtp_port = r['remote_port']
@@ -173,23 +172,27 @@
 rtpctrl_act = RtpSourceCtrlActor.start(RTPSOURCE_CTRL_IP, RTPSOURCE_CTRL_PORT)
 
 # convenience wrapper
-def mt_call(msisdn_called, msisdn_calling = '123456789', codecs = GSM48.AllCodecs):
+def mt_call(msisdn_called, msisdn_calling='123456789', codecs=GSM48.AllCodecs, codec='GSM_FR'):
     call_conn = MTCallRtpsource.start(mncc_act, rtpctrl_act, codecs).proxy()
-    call_conn.start_call(msisdn_called, msisdn_calling)
+    call_conn.start_call(msisdn_called, msisdn_calling, codec)
     return call_conn
 
-def calls(nr, ramp=1.0):
+def calls(nr, ramp=1.0, codec='GSM_FR'):
     for i in range(nr):
         a = 90001 + i
         a = str(a)
         print("%d: mt_call(%r)" % (i, a))
-        mt_call(a)
+        mt_call(a, codec=codec)
         time.sleep(ramp)
 
 log.info("")
 log.info("")
-log.info("Start calls by typing:")
+log.info("Start a single call by typing:")
 log.info("    mt_call('90001')")
+log.info("With a specific codec (default is 'GSM_FR'):")
+log.info("    mt_call('90001', codec='GSM_EFR')")
+log.info("Start multiple calls with (e.g. 4 calls with EFR):")
+log.info("    calls(4, codec='GSM_EFR')")
 log.info("")
 log.info("")
 

-- 
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200501/9b268c0e/attachment.htm>