<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/mncc-python/+/17980">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  osmith: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc_mt_loadgen.py: add codec arg<br><br>Add codec parameter to start_call() and convenience functions mt_call()<br>and calls() with FR as default. While at it, update the help text.<br><br>Related: SYS#4924<br>Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4<br>---<br>M mncc_mt_loadgen.py<br>1 file changed, 10 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py</span><br><span>index 5f15e3b..e401fcb 100755</span><br><span>--- a/mncc_mt_loadgen.py</span><br><span>+++ b/mncc_mt_loadgen.py</span><br><span>@@ -109,12 +109,11 @@</span><br><span>         self.state = 'NULL'</span><br><span>         self.rtp_msc = None</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def start_call(self, msisdn_called, msisdn_calling):</span><br><span style="color: hsl(120, 100%, 40%);">+    def start_call(self, msisdn_called, msisdn_calling, codec):</span><br><span>         '''Start a MT call from given [external] calling party to given mobile party MSISDN'''</span><br><span>         self.msisdn_called = msisdn_called</span><br><span>         self.msisdn_calling = msisdn_calling</span><br><span>         # allocate a RTP connection @ rtpsource</span><br><span style="color: hsl(0, 100%, 40%);">-        codec = "GSM_FR"  # FIXME: make configurable</span><br><span>         r = self.ctrl_act.ask({'type':'rtp_create', 'cname':self.callref, 'codec':codec})</span><br><span>         self.ext_rtp_host = r['remote_host']</span><br><span>         self.ext_rtp_port = r['remote_port']</span><br><span>@@ -173,23 +172,27 @@</span><br><span> rtpctrl_act = RtpSourceCtrlActor.start(RTPSOURCE_CTRL_IP, RTPSOURCE_CTRL_PORT)</span><br><span> </span><br><span> # convenience wrapper</span><br><span style="color: hsl(0, 100%, 40%);">-def mt_call(msisdn_called, msisdn_calling = '123456789', codecs = GSM48.AllCodecs):</span><br><span style="color: hsl(120, 100%, 40%);">+def mt_call(msisdn_called, msisdn_calling='123456789', codecs=GSM48.AllCodecs, codec='GSM_FR'):</span><br><span>     call_conn = MTCallRtpsource.start(mncc_act, rtpctrl_act, codecs).proxy()</span><br><span style="color: hsl(0, 100%, 40%);">-    call_conn.start_call(msisdn_called, msisdn_calling)</span><br><span style="color: hsl(120, 100%, 40%);">+    call_conn.start_call(msisdn_called, msisdn_calling, codec)</span><br><span>     return call_conn</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-def calls(nr, ramp=1.0):</span><br><span style="color: hsl(120, 100%, 40%);">+def calls(nr, ramp=1.0, codec='GSM_FR'):</span><br><span>     for i in range(nr):</span><br><span>         a = 90001 + i</span><br><span>         a = str(a)</span><br><span>         print("%d: mt_call(%r)" % (i, a))</span><br><span style="color: hsl(0, 100%, 40%);">-        mt_call(a)</span><br><span style="color: hsl(120, 100%, 40%);">+        mt_call(a, codec=codec)</span><br><span>         time.sleep(ramp)</span><br><span> </span><br><span> log.info("")</span><br><span> log.info("")</span><br><span style="color: hsl(0, 100%, 40%);">-log.info("Start calls by typing:")</span><br><span style="color: hsl(120, 100%, 40%);">+log.info("Start a single call by typing:")</span><br><span> log.info("    mt_call('90001')")</span><br><span style="color: hsl(120, 100%, 40%);">+log.info("With a specific codec (default is 'GSM_FR'):")</span><br><span style="color: hsl(120, 100%, 40%);">+log.info("    mt_call('90001', codec='GSM_EFR')")</span><br><span style="color: hsl(120, 100%, 40%);">+log.info("Start multiple calls with (e.g. 4 calls with EFR):")</span><br><span style="color: hsl(120, 100%, 40%);">+log.info("    calls(4, codec='GSM_EFR')")</span><br><span> log.info("")</span><br><span> log.info("")</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/mncc-python/+/17980">change 17980</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/mncc-python/+/17980"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: mncc-python </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4 </div>
<div style="display:none"> Gerrit-Change-Number: 17980 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>