Change in osmocom-bb[master]: mobile: loopback voice frames

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Mar 30 16:36:40 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )

Change subject: mobile: loopback voice frames
......................................................................


Patch Set 4:

> Patch Set 4: Code-Review-1
> 
> should be configurable

It is configurable, as prepared by the previous patch

  if (ms->settings.audio.io_target == AUDIO_IO_LOOPBACK)

It may look non-configurable, because I move the msgb-pull above, as a common part.

When I submitted the patch, I had decided to always do the msgb stuff unconditionally, but thinking again it might be worth it to skip the entire msgb-pull if it isn't used.


-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83
Gerrit-Change-Number: 17381
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 16:36:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/90dfafa4/attachment.htm>


More information about the gerrit-log mailing list