<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">should be configurable</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">It is configurable, as prepared by the previous patch</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  if (ms->settings.audio.io_target == AUDIO_IO_LOOPBACK)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">It may look non-configurable, because I move the msgb-pull above, as a common part.</p><p style="white-space: pre-wrap; word-wrap: break-word;">When I submitted the patch, I had decided to always do the msgb stuff unconditionally, but thinking again it might be worth it to skip the entire msgb-pull if it isn't used.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17381">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17381">change 17381</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17381"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83 </div>
<div style="display:none"> Gerrit-Change-Number: 17381 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 30 Mar 2020 16:36:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>