Change in osmo-bsc[master]: fix append_gprs_cell_opt(): properly set Access Burst Type in SI13

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17654 )


Change subject: fix append_gprs_cell_opt(): properly set Access Burst Type in SI13
......................................................................

fix append_gprs_cell_opt(): properly set Access Burst Type in SI13

According to section 7.4a of 3GPP TS 44.004, two alternative RACH
block formats are specified: 8-bit (1 octet) and 11-bit. As per
3GPP TS 44.060, section 12.24, the actual format is indicated in
GPRS Cell Options IE, which is a part of System Information 13.

A VTY option to control the Access Burst format was introduced
a long time ago (in 2016!), but never had the actual effect.

Let's finally fix this.

Change-Id: Iac66a675d64b1c32d8a61a0229e44b35bf2a1414
Fixes: I51357bec936c28a26ab9ff5d59e0e30ca3363297
---
M src/osmo-bsc/rest_octets.c
1 file changed, 3 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/17654/1

diff --git a/src/osmo-bsc/rest_octets.c b/src/osmo-bsc/rest_octets.c
index 1d2279b..236d30b 100644
--- a/src/osmo-bsc/rest_octets.c
+++ b/src/osmo-bsc/rest_octets.c
@@ -788,8 +788,8 @@
 
 	bitvec_set_uint(bv, t3192, 3);
 	bitvec_set_uint(bv, drx_timer_max, 3);
-	/* ACCESS_BURST_TYPE: Hard-code 8bit */
-	bitvec_set_bit(bv, 0);
+	/* ACCESS_BURST_TYPE: 8-bit (0) or 11-bit (1) */
+	bitvec_set_bit(bv, gco->supports_egprs_11bit_rach);
 	/* CONTROL_ACK_TYPE: */
 	bitvec_set_bit(bv, gco->ctrl_ack_type_use_block);
 	bitvec_set_uint(bv, gco->bs_cv_max, 4);
@@ -823,12 +823,7 @@
 			bitvec_set_bit(bv, 1);
 
 			/* 1bit EGPRS PACKET CHANNEL REQUEST */
-			if (gco->supports_egprs_11bit_rach == 0) {
-				bitvec_set_bit(bv,
-					gco->ext_info.use_egprs_p_ch_req);
-			} else {
-				bitvec_set_bit(bv, 0);
-			}
+			bitvec_set_bit(bv, gco->ext_info.use_egprs_p_ch_req);
 
 			/* 4bit BEP PERIOD */
 			bitvec_set_uint(bv, gco->ext_info.bep_period, 4);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iac66a675d64b1c32d8a61a0229e44b35bf2a1414
Gerrit-Change-Number: 17654
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200329/19baa55d/attachment.htm>