<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17654">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix append_gprs_cell_opt(): properly set Access Burst Type in SI13<br><br>According to section 7.4a of 3GPP TS 44.004, two alternative RACH<br>block formats are specified: 8-bit (1 octet) and 11-bit. As per<br>3GPP TS 44.060, section 12.24, the actual format is indicated in<br>GPRS Cell Options IE, which is a part of System Information 13.<br><br>A VTY option to control the Access Burst format was introduced<br>a long time ago (in 2016!), but never had the actual effect.<br><br>Let's finally fix this.<br><br>Change-Id: Iac66a675d64b1c32d8a61a0229e44b35bf2a1414<br>Fixes: I51357bec936c28a26ab9ff5d59e0e30ca3363297<br>---<br>M src/osmo-bsc/rest_octets.c<br>1 file changed, 3 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/17654/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/rest_octets.c b/src/osmo-bsc/rest_octets.c</span><br><span>index 1d2279b..236d30b 100644</span><br><span>--- a/src/osmo-bsc/rest_octets.c</span><br><span>+++ b/src/osmo-bsc/rest_octets.c</span><br><span>@@ -788,8 +788,8 @@</span><br><span> </span><br><span>   bitvec_set_uint(bv, t3192, 3);</span><br><span>       bitvec_set_uint(bv, drx_timer_max, 3);</span><br><span style="color: hsl(0, 100%, 40%);">-  /* ACCESS_BURST_TYPE: Hard-code 8bit */</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec_set_bit(bv, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        /* ACCESS_BURST_TYPE: 8-bit (0) or 11-bit (1) */</span><br><span style="color: hsl(120, 100%, 40%);">+      bitvec_set_bit(bv, gco->supports_egprs_11bit_rach);</span><br><span>       /* CONTROL_ACK_TYPE: */</span><br><span>      bitvec_set_bit(bv, gco->ctrl_ack_type_use_block);</span><br><span>         bitvec_set_uint(bv, gco->bs_cv_max, 4);</span><br><span>@@ -823,12 +823,7 @@</span><br><span>                    bitvec_set_bit(bv, 1);</span><br><span> </span><br><span>                   /* 1bit EGPRS PACKET CHANNEL REQUEST */</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (gco->supports_egprs_11bit_rach == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                           bitvec_set_bit(bv,</span><br><span style="color: hsl(0, 100%, 40%);">-                                      gco->ext_info.use_egprs_p_ch_req);</span><br><span style="color: hsl(0, 100%, 40%);">-                   } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                                bitvec_set_bit(bv, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-                  }</span><br><span style="color: hsl(120, 100%, 40%);">+                     bitvec_set_bit(bv, gco->ext_info.use_egprs_p_ch_req);</span><br><span> </span><br><span>                         /* 4bit BEP PERIOD */</span><br><span>                        bitvec_set_uint(bv, gco->ext_info.bep_period, 4);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17654">change 17654</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17654"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iac66a675d64b1c32d8a61a0229e44b35bf2a1414 </div>
<div style="display:none"> Gerrit-Change-Number: 17654 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>