Change in osmo-pcu[master]: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 23 19:33:48 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17581 )


Change subject: rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate
......................................................................

rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate

This a leftover from I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198.
Most of the CSN.1 codec related logging messages are now using
LOGL_DEBUG, so the rlcmac code should also do the same.

Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016
---
M src/gsm_rlcmac.cpp
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/17581/1

diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp
index c1dc80e..03e0417 100644
--- a/src/gsm_rlcmac.cpp
+++ b/src/gsm_rlcmac.cpp
@@ -4978,7 +4978,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to start the log somewhere... */
   msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);
-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d)): ",
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d)): ",
        msg_type_name, data->u.MESSAGE_TYPE);
   switch (data->u.MESSAGE_TYPE)
   {
@@ -5065,7 +5065,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
      newline, so as a caller we are responisble for submitting it */
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0) {
     LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by decoder at the end of bitvec\n", msg_type_name, ret);
@@ -5140,7 +5140,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to start the log somewhere... */
   msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);
-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d): ",
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d): ",
        msg_type_name, data->u.MESSAGE_TYPE);
 
   switch (data->u.MESSAGE_TYPE)
@@ -5277,7 +5277,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
      newline, so as a caller we are responisble for submitting it */
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0) {
     LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by decoder at the end of bitvec\n", msg_type_name, ret);
@@ -5301,7 +5301,7 @@
 
   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */
   msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);
-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",
        msg_type_name, data->u.MESSAGE_TYPE);
   switch (data->u.MESSAGE_TYPE)
   {
@@ -5388,7 +5388,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
      newline, so as a caller we are responisble for submitting it */
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {
     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode an Uplink block: not enough bits "
@@ -5462,7 +5462,7 @@
 
   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */
   msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);
-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",
        msg_type_name, data->u.MESSAGE_TYPE);
   switch (data->u.MESSAGE_TYPE)
   {
@@ -5598,7 +5598,7 @@
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
      newline, so as a caller we are responisble for submitting it */
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {
     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode a Downlink block: not enough bits "
@@ -5754,12 +5754,12 @@
   csnStreamInit(&ar, 0, 8 * vector->data_len);
 
   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */
-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (RAcap): ");
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (RAcap): ");
   ret = csnStreamDecoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, &readIndex, data);
 
   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing
      newline, so as a caller we are responisble for submitting it */
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0) {
     LOGP(DRLCMACDATA, LOGL_NOTICE, "RAcap: Got %d remaining bits unhandled by decoder at the end of bitvec\n", ret);
@@ -5780,9 +5780,9 @@
   csnStreamInit(&ar, 0, vector->data_len * 8);
 
   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */
-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (RAcap): ");
+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (RAcap): ");
   ret = csnStreamEncoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, &writeIndex, data);
-  LOGPC(DCSN1, LOGL_INFO, "\n");
+  LOGPC(DCSN1, LOGL_DEBUG, "\n");
 
   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {
     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode MS RA Capability IE: not enough bits "

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17581
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016
Gerrit-Change-Number: 17581
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200323/4342d3f0/attachment.htm>


More information about the gerrit-log mailing list