<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17581">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rlcmac: use LOGL_DEBUG instead of LOGL_INFO where appropriate<br><br>This a leftover from I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198.<br>Most of the CSN.1 codec related logging messages are now using<br>LOGL_DEBUG, so the rlcmac code should also do the same.<br><br>Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016<br>---<br>M src/gsm_rlcmac.cpp<br>1 file changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/17581/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp</span><br><span>index c1dc80e..03e0417 100644</span><br><span>--- a/src/gsm_rlcmac.cpp</span><br><span>+++ b/src/gsm_rlcmac.cpp</span><br><span>@@ -4978,7 +4978,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span>   msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d)): ",</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d)): ",</span><br><span>        msg_type_name, data->u.MESSAGE_TYPE);</span><br><span>   switch (data->u.MESSAGE_TYPE)</span><br><span>   {</span><br><span>@@ -5065,7 +5065,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing</span><br><span>      newline, so as a caller we are responisble for submitting it */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by decoder at the end of bitvec\n", msg_type_name, ret);</span><br><span>@@ -5140,7 +5140,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span>   msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (type: %s (%d): ",</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (type: %s (%d): ",</span><br><span>        msg_type_name, data->u.MESSAGE_TYPE);</span><br><span> </span><br><span>   switch (data->u.MESSAGE_TYPE)</span><br><span>@@ -5277,7 +5277,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing</span><br><span>      newline, so as a caller we are responisble for submitting it */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_NOTICE, "%s: Got %d remaining bits unhandled by decoder at the end of bitvec\n", msg_type_name, ret);</span><br><span>@@ -5301,7 +5301,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span>   msg_type_name = get_value_string(rlcmac_ul_msg_names, data->u.MESSAGE_TYPE);</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",</span><br><span>        msg_type_name, data->u.MESSAGE_TYPE);</span><br><span>   switch (data->u.MESSAGE_TYPE)</span><br><span>   {</span><br><span>@@ -5388,7 +5388,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing</span><br><span>      newline, so as a caller we are responisble for submitting it */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode an Uplink block: not enough bits "</span><br><span>@@ -5462,7 +5462,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span>   msg_type_name = get_value_string(rlcmac_dl_msg_names, data->u.MESSAGE_TYPE);</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (type: %s (%d)): ",</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (type: %s (%d)): ",</span><br><span>        msg_type_name, data->u.MESSAGE_TYPE);</span><br><span>   switch (data->u.MESSAGE_TYPE)</span><br><span>   {</span><br><span>@@ -5598,7 +5598,7 @@</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing</span><br><span>      newline, so as a caller we are responisble for submitting it */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode a Downlink block: not enough bits "</span><br><span>@@ -5754,12 +5754,12 @@</span><br><span>   csnStreamInit(&ar, 0, 8 * vector->data_len);</span><br><span> </span><br><span>   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamDecoder (RAcap): ");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamDecoder (RAcap): ");</span><br><span>   ret = csnStreamDecoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, &readIndex, data);</span><br><span> </span><br><span>   /* recursive csnStreamDecoder call uses LOGPC everywhere without trailing</span><br><span>      newline, so as a caller we are responisble for submitting it */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_NOTICE, "RAcap: Got %d remaining bits unhandled by decoder at the end of bitvec\n", ret);</span><br><span>@@ -5780,9 +5780,9 @@</span><br><span>   csnStreamInit(&ar, 0, vector->data_len * 8);</span><br><span> </span><br><span>   /* recursive csnStreamEncoder call uses LOGPC everywhere, so we need to start the log somewhere... */</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGP(DCSN1, LOGL_INFO, "csnStreamEncoder (RAcap): ");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DCSN1, LOGL_DEBUG, "csnStreamEncoder (RAcap): ");</span><br><span>   ret = csnStreamEncoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, &writeIndex, data);</span><br><span style="color: hsl(0, 100%, 40%);">-  LOGPC(DCSN1, LOGL_INFO, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPC(DCSN1, LOGL_DEBUG, "\n");</span><br><span> </span><br><span>   if (ret > 0 || ret == CSN_ERROR_NEED_MORE_BITS_TO_UNPACK) {</span><br><span>     LOGP(DRLCMACDATA, LOGL_ERROR, "Failed to encode MS RA Capability IE: not enough bits "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17581">change 17581</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17581"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I22f56cbcf2ee7339518300288c6d7f60a483a016 </div>
<div style="display:none"> Gerrit-Change-Number: 17581 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>