This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19051 ) Change subject: Introduce rate counter tx_stale_bursts ...................................................................... Patch Set 1: Code-Review+1 (3 comments) cosmetics... https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/osmo_signal.h File CommonLibs/osmo_signal.h: https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/osmo_signal.h@60 PS1, Line 60: /* signal cb for signal <SS_DEVICE,S_TRX_COUNTER_CHANGE> */ technically a cb is a callback is a function, this would be data (but i see the same mistake above) https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/trx_rate_ctr.cpp File CommonLibs/trx_rate_ctr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/trx_rate_ctr.cpp@83 PS1, Line 83: static Mutex trx_rate_ctr_mutex; oof, now you're also interleaving globals of different realms ... i think two separate struct instances would be much nicer, could even re-use the struct definition for both, right? Maybe also possible to reduce code dup below a bit https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/trx_rate_ctr.cpp@161 PS1, Line 161: LOGC(DMAIN, NOTICE) << "Main thread is updating Transceiver counters"; (looks more like DEBUG to me, but copying above code, i see) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6df00da81f6d6884f4dddc5a2c4b354dca3af97 Gerrit-Change-Number: 19051 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2020 16:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/954e41b2/attachment.htm>