Change in osmo-trx[master]: Introduce rate counter tx_stale_bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 29 16:55:07 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19051 )

Change subject: Introduce rate counter tx_stale_bursts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/trx_rate_ctr.cpp 
File CommonLibs/trx_rate_ctr.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/19051/1/CommonLibs/trx_rate_ctr.cpp@83 
PS1, Line 83: static Mutex trx_rate_ctr_mutex;
> oof, now you're also interleaving globals of different realms ... […]
I just tried and it's not possible because one would be holding a "trx_counters" and another one a "device_counters", so only the mutex and the timerfd would be joined, and I see not much benefit. It's fine as it is now, if it needs to be extended afterwards the it can  be improved as needed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19051
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id6df00da81f6d6884f4dddc5a2c4b354dca3af97
Gerrit-Change-Number: 19051
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jun 2020 16:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/0856063d/attachment.htm>


More information about the gerrit-log mailing list